Repository navigation
fix: Unable to select payment option in the dropdown in expense preview in the main chat - #51645
Conversation
…ew in the main chat
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@jayeshmangwani I encountered an error when running IOS native: I will test and update the IOS native video when it is fixed. |
Try to clean node_modules and run again, you can do |
|
@truph01 Would you mind uploading the iOS video here? |
It works. I just added IOS video. |
|
@truph01 would you update the tests steps to be more clear on this point ?
How to Send an Invoice to a User (whats the prerequisite ?) |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid.mp4Android: mWeb Chromemweb-chrome.moviOS: NativeiOS.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
jayeshmangwani
left a comment
There was a problem hiding this comment.
Changes works well, LGTM 🚀
|
@aldo-expensify Changes works well and suggested here to update a Test step Currently, we’re seeing 0.00 for the invoice receiver, and this issue is being addressed here: #51312 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.56-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.56-9 🚀
|

Details
Fixed Issues
$ #51016
PROPOSAL: #51016 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-10-29.at.18.35.46.mov
Android: mWeb Chrome
Screen.Recording.2024-10-29.at.18.34.58.mov
iOS: Native
Screen.Recording.2024-10-30.at.14.22.57.mov
iOS: mWeb Safari
Screen.Recording.2024-10-29.at.18.34.01.mov
MacOS: Chrome / Safari
Screen.Recording.2024-10-29.at.18.31.19.mov
MacOS: Desktop
Screen.Recording.2024-10-29.at.18.44.15.mov